Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: node-index, auth key interaction, and YAML support #1044

Merged
merged 3 commits into from
Apr 18, 2024
Merged

feat: node-index, auth key interaction, and YAML support #1044

merged 3 commits into from
Apr 18, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Apr 3, 2024 •
edited
Loading

ref: #795

Summary

Adds node index and auth key interaction commands for the local-ic action handler. Required for private testnet networks (rather than using bash).

Also now supports YAML for configs (comments are nice sometimes)

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 8:22pm

@Reecepbcups Reecepbcups changed the title feat: node-index and auth key interaction feat: node-index, auth key interaction, and YAML support Apr 17, 2024
Reecepbcups
Reecepbcups commented Apr 17, 2024
View reviewed changes
Copy link
Member Author

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with running hub, hub.yml, cosmoshub, cosmoshub.json and a remote github - all started up and read as expected

local-interchain/cmd/local-ic/start_chain.go Show resolved Hide resolved
@Reecepbcups Reecepbcups marked this pull request as ready for review April 17, 2024 20:24
@Reecepbcups Reecepbcups requested a review from a team as a code owner April 17, 2024 20:24
@Reecepbcups Reecepbcups enabled auto-merge (squash) April 17, 2024 20:32
jtieri
jtieri approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Reecepbcups Reecepbcups merged commit 97a1561 into main Apr 18, 2024
19 checks passed
@Reecepbcups Reecepbcups deleted the reece/localic-improvements branch April 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

@pharr117 pharr117 Awaiting requested review from pharr117 pharr117 is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
local-interchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reecepbcups @jtieri